Bump parsl 11 25 and remove reference to removed method #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
no-news-is-good-news
LeiGlobus
requested review from
yadudoc,
chris-janidlo,
rjmello and
khk-globus
rjmello
reviewed
Nov 26, 2024
compute_endpoint/globus_compute_endpoint/engines/high_throughput/interchange.py
Outdated
Show resolved
Hide resolved
rjmello
reviewed
Nov 26, 2024
LeiGlobus
force-pushed
the
bump_parsl_11_25
branch
from
65a13b6 to
47ac12c
Compare
rjmello
previously approved these changes
Nov 26, 2024
LeiGlobus
force-pushed
the
bump_parsl_11_25
branch
from
47ac12c to
cf4540e
Compare
LeiGlobus
removed
the
no-news-is-good-news
LeiGlobus
force-pushed
the
bump_parsl_11_25
branch
from
cf4540e to
1cb3591
Compare
rjmello
approved these changes
Nov 26, 2024
|
[sc-37307] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping parsl mostly works, except that Compute uses a method that's been removed/cleaned up in Parsl:
Parsl/parsl#3689
The original code does a redundant makedirs anyway - if the child is made, the parent is also created.
edit However, I left the parent's makedirs() in anyway, because the original child dir creation had a different default permission, just in case.