Mild executor fixture refactor #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4f6e7aa, the `gc_executor` started using `MockedExecutor`. This also removed the need to create a separate mocked Client. To keep the change at the time focused on that, the changeset did not remove the now-superfluous `gcc` part of the yield. This changeset now cleans up that refactor, and the core of this change is: ```diff -def gc_executor(mock_result_watcher): - gce = MockedExecutor() - yield gce.client, gce +def gce(mock_result_watcher): + gc_executor = MockedExecutor() + yield gc_executor ``` The `yield` statement is the key change, but the renaming of the fixture is intended to reduce the other necessary changes, since the tests that use this fixture use `gce` as their executor variable.
khk-globus
added
no-news-is-good-news
rjmello
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4f6e7aa (#1421), the
gc_executorstarted usingMockedExecutor. This also removed the need to create a separate mocked Client. To keep the change at the time focused on that, the changeset did not remove the now-superfluousgccpart of the yield.This changeset now cleans up that refactor, and the core of this change is:
The
yieldstatement is the key change, but the renaming of the fixture is intended to reduce the other necessary changes, since the tests that use this fixture usegceas their executor variable.Type of change