Skip to content

Commit

Permalink
Fix operator precedence in Jupyter checking
Browse files Browse the repository at this point in the history
Update `globus_app.py` to match `login_manager/manager.py`
  • Loading branch information
chris-janidlo committed Oct 1, 2024
1 parent f2b7a44 commit f53abd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion compute_sdk/globus_compute_sdk/sdk/auth/globus_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def get_globus_app(environment: str | None = None):

# The authorization-via-web-link flow requires stdin; the user must visit
# the web link and enter generated code.
elif not sys.stdin.isatty() or sys.stdin.closed and not _is_jupyter():
elif (not sys.stdin.isatty() or sys.stdin.closed) and not _is_jupyter():
# Not technically necessary; the login flow would just die with an EOF
# during input(), but adding this message here is much more direct --
# handle the non-happy path by letting the user know precisely the issue
Expand Down

0 comments on commit f53abd0

Please sign in to comment.