Variable-ize identifier length

globus · Dec 6, 2024 · dab79a1 · dab79a1
1 parent 8a077e3
commit dab79a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/compute_sdk/globus_compute_sdk/serialize/base.py b/compute_sdk/globus_compute_sdk/serialize/base.py
@@ -2,12 +2,20 @@
 
 from globus_compute_sdk.errors import DeserializationError
 
+# 2 unique characters and a newline
+IDENTIFIER_LENGTH = 3
+
 
 class SerializationStrategy(metaclass=ABCMeta):
     """A SerializationStrategy is in charge of converting function source code or
     arguments into string data and back again.
     """
 
+    def __init_subclass__(cls):
+        super().__init_subclass__()
+        if len(cls.identifier) != IDENTIFIER_LENGTH:
+            raise ValueError(f"Identifiers must be {IDENTIFIER_LENGTH} characters long")
+
     @property
     @abstractmethod
     def identifier(self):

diff --git a/compute_sdk/globus_compute_sdk/serialize/facade.py b/compute_sdk/globus_compute_sdk/serialize/facade.py
@@ -4,7 +4,7 @@
 import typing as t
 
 from globus_compute_sdk.errors import DeserializationError, SerializationError
-from globus_compute_sdk.serialize.base import SerializationStrategy
+from globus_compute_sdk.serialize.base import IDENTIFIER_LENGTH, SerializationStrategy
 from globus_compute_sdk.serialize.concretes import (
     DEFAULT_STRATEGY_CODE,
     DEFAULT_STRATEGY_DATA,
@@ -41,9 +41,7 @@ def validate(strategy: SerializationStrategy) -> SerializationStrategy:
             validate(strategy_data) if strategy_data else DEFAULT_STRATEGY_DATA
         )
 
-        # grab a randomish ID from the map (all identifiers should be the same length)
-        identifier = next(iter(STRATEGIES_MAP.keys()))
-        self.header_size = len(identifier)
+        self.header_size = IDENTIFIER_LENGTH
 
         self.strategies = {
             header: strategy_class()