Skip to content

Commit

Permalink
Fix broken ScalingFailed exception construction
Browse files Browse the repository at this point in the history
This tries to find the provider label inside self.config.provider,
which does not exist. In this interchange, the provider is
directly available as an attribute.

Tested by: modify my local kube provider to return None on
all submits, see that the issue #679 stack trace appears.
Make this change in this commit, and see that a ScalingFailed
correctly appears.

This addresses the first bullet point in issue #679.
  • Loading branch information
benclifford committed Feb 2, 2022
1 parent 51b9198 commit be4afd3
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ def scale_out(self, blocks=1, task_type=None):
if not internal_block:
raise (
ScalingFailed(
self.config.provider.label,
self.provider.label,
"Attempts to provision nodes via provider has failed",
)
)
Expand Down

0 comments on commit be4afd3

Please sign in to comment.