PR changes

compute_endpoint/globus_compute_endpoint/engines/high_throughput/engine.py

@@ -302,8 +302,9 @@ def __init__(
 
         if not HighThroughputEngine.is_hostname_or_ip(address):
             err_msg = (
-                f"Invalid address supplied: ({address}) "
-                "Please use a valid hostname or IPv4/IPv6 address"
+                # yes, suggesting `=` formatter, so it's clear which argument.
+                f"Invalid address: {address=}\n\n"
+                "Expecting an interface name, hostname, IPv4 address, or IPv6 address."
             )
             log.critical(err_msg)
             raise ValueError(err_msg)
@@ -424,8 +425,7 @@ def start(
     def is_hostname_or_ip(hostname_or_ip: str) -> bool:
         """
         Utility method to verify that the input is a valid hostname or
-        IP address.   This is potentially useful elsewhere, if used,
-        should we move it to another module?
+        IP address.
         """
         if not hostname_or_ip:
             return False

compute_endpoint/tests/unit/test_engines.py

@@ -414,5 +414,4 @@ def test_gcmpiengine_accepts_resource_specification(task_uuid, randomstring):
     ),
 )
 def test_hostname_or_ip_validation(input, is_valid):
-    result = HighThroughputEngine.is_hostname_or_ip(input)
-    assert is_valid == result
+    assert HighThroughputEngine.is_hostname_or_ip(input) is is_valid