Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to click v7.x and cleanup custom code in the process #465

Closed
6 tasks
sirosen opened this issue May 8, 2019 · 0 comments · Fixed by #466
Closed
6 tasks

Update to click v7.x and cleanup custom code in the process #465

sirosen opened this issue May 8, 2019 · 0 comments · Fixed by #466
Assignees
Labels
enhancement New feature or improvement maintenance Internal improvements (e.g. tests)

Comments

@sirosen
Copy link
Member

sirosen commented May 8, 2019

  • Look at the click 7.0 changelog
  • open a branch with the update, test the results
    • make sure to use each option type and option set
    • take time with this, don't rush
  • add any new tests for changes in behavior which we want to check
    • e.g. check that cmd --help does not include hidden opts
    • stick to non-network tests, as we want to do the same kind of change that we did in globus-sdk
  • merge to master and release as a minor version update
    • no intentional breaking behavioral changes should be made
    • avoid bundling this with other updates
@sirosen sirosen added enhancement New feature or improvement maintenance Internal improvements (e.g. tests) labels May 8, 2019
@sirosen sirosen self-assigned this May 8, 2019
sirosen added a commit to sirosen/globus-cli that referenced this issue Jul 19, 2019
In one of the intermediate commits of globus#465, JMESPath ParseError handling
had to be reworked a bit to handle the top-level exception handling
being changed. But this change actually results in more verbose, worse
errors for the most part. It's better to handle these the way we were
doing before, so this reverts the change.
sirosen added a commit to sirosen/globus-cli that referenced this issue Jul 19, 2019
In one of the intermediate commits of globus#465, JMESPath ParseError handling
had to be reworked a bit to handle the top-level exception handling
being changed. But this change actually results in more verbose, worse
errors for the most part. It's better to handle these the way we were
doing before, so this reverts the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement maintenance Internal improvements (e.g. tests)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant