Use internal.MutexByRoom

globekeeper · Jun 28, 2021 · 138cddc · 138cddc
1 parent 6e6f026
commit 138cddc
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/federationapi/routing/send.go b/federationapi/routing/send.go
@@ -620,18 +620,13 @@ func checkAllowedByState(e *gomatrixserverlib.Event, stateEvents []*gomatrixserv
 	return gomatrixserverlib.Allowed(e, &authUsingState)
 }
 
-var processEventWithMissingStateMutexes = map[string]*sync.Mutex{}
+var processEventWithMissingStateMutexes = &internal.MutexByRoom{}
 
 func (t *txnReq) processEventWithMissingState(
 	ctx context.Context, e *gomatrixserverlib.Event, roomVersion gomatrixserverlib.RoomVersion,
 ) error {
-	mu, ok := processEventWithMissingStateMutexes[e.RoomID()]
-	if !ok {
-		processEventWithMissingStateMutexes[e.RoomID()] = &sync.Mutex{}
-		mu = processEventWithMissingStateMutexes[e.RoomID()]
-	}
-	mu.Lock()
-	defer mu.Unlock()
+	processEventWithMissingStateMutexes.Lock(e.RoomID())
+	defer processEventWithMissingStateMutexes.Unlock(e.RoomID())
 
 	// Do this with a fresh context, so that we keep working even if the
 	// original request times out. With any luck, by the time the remote