development: revert #61 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90c056c.
- use last minor version for each major serie of
mongodb
- use travis 'go' param instead of eval "$(gimme $GO)"
as it fails to install correctly last minor version
( 1.8.x notation for example)
also re-enable TestFindIterSnapshot as it was fixed a long time ago
fix TestAuthX509CredRDNConstruction test: need to
create an user with {"username": subject} before
trying to login
Make sure that "rs3/127.0.0.1/40031" is elected at primary. Create user before running 'addShard' command as it requires root access Also add a retry mechanism to make sure that shard are correctly added cf https://docs.mongodb.com/manual/tutorial/deploy-shard-cluster/
domodwyer
requested review from
szank,
brknstrngz,
tadukurow,
weiishann,
csucu and
eminano
weiishann
approved these changes
Jan 8, 2018
tadukurow
approved these changes
Jan 8, 2018
szank
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The production driver / master branch (used by
go get) is NOT affected by this PR.Testing development (a104bfb) revealed an issue with authentication introduced by #61 which was patched via d711d75.
Unfortunately further testing revealed select throughput that gets worse over time, as well as a significant increase in throughput variance for insert and update workloads.
After running for 1 hour, select performance continued to decline:
This PR reverts #61 so we can release an update of mgo, however I have branched the current state of development off to feature/OP_MSG-support in order to continue work and hopefully get it merged back into development.
Commits compared:
d711d75d53edee739c66b0dcfaf8192894ef2bae)r2017.11.06)Analysis: