fix golint, go vet and go fmt #44

feliixx · 2017-09-28T10:52:17Z

WIP - Do not merge

This PR is an attempt to fix golint, go vet and gofmt warning of all files in the project ( see #43 for details)

A few warnings are still raised by go vet:

session.go:661: assignment copies lock value to scopy: mgo.Session contains sync.RWMutex

-> not sure how to handle this one

internal/json/decode_test.go:1350: struct field m has json tag but is not exported
internal/json/decode_test.go:1351: struct field m2 has json tag but is not exported
internal/json/tagkey_test.go:56: struct field tag `:"BadFormat"` not compatible with reflect.StructTag.Get: bad syntax for struct tag key

-> part of the tests and intended to be badly formatted.

I was able to fix all golint warnings, but bad news is that it currently breaks backward compatibility...
golint raise warnings about Id not being ID, and theres many occurence of this in mgo (ObjectId, FindId() ...)

This might be fixed with type alias to preserve backward compatibility ?

Waiting for any feedback on this,

Feliixx

domodwyer · 2017-09-28T14:51:31Z

Hey @feliixx

I just had a quick look at the mutex thing - copySession() is creating a shallow copy of the struct (so same pointers, etc but fields referenced by value are copied). Essentially it's a lazy way of doing:

scopy := Session{
    defaultdb: session.defaultdb,
    sourcedb: session.sourcedb,
    ...
    m: sync.Mutex{},
    ...
}

So long as this is the only place a session is copied (and it looks like it is, otherwise you'd have more mutex copy errors) the above change should be fine.

I'm aware of the other two - and I really don't like what I'm about to suggest...

For the struct tags, I think in this case disabling vet's struct tag checks might be best - we could do some fancy stuff with build tags but it's a bit hard to reason about.

If the tags are malformed the code won't work, and this should be caught by any unit tests added alongside any new structs with tags.

For the Id => ID conversion - again, sorry! - I'd rather keep backwards compatibility and not run golint as part of the CI - apparently it's not really supposed to be used for this purpose anyway (see here).

I don't think type aliasing will be able to help us with the ID thing but I'm definitely open to ideas - we'd have to do it when 1.9 is a little "older" - a lot of people will currently still be using 1.8 and earlier.

As always, genuinely grateful for the time you've put in contributing - thanks!

Dom

feliixx · 2017-09-28T16:29:56Z

Hey @domodwyer,

Totally understand that keeping backward compatibility is more important.

I removed all Id/ID related changes, and fixed the warning in copySession()

So here is a solution :

run golint ./... | grep -v 'ID' | cat so warnings about Id/ID aren't printed, but all other are. If some warnings are found, the build does not fail
run go vet on exported packages only (mgo, mgo/bson and mgo/txn). Content of internal would not be tested . If warnings are found, the build fails

Feliixx

domodwyer · 2017-09-29T13:14:05Z

Hey @feliixx

Both are good solutions for me :) Any idea why tests on 3.0.X always fail? I've retried them a bunch of times.

Dom

feliixx · 2017-10-02T08:39:06Z

Hi @domodwyer,

tests on 3.0.x were failing because the command drop doesn't return the same error as 2.6, 3.2 & 3.4 when trying to delete a collection that doesn't exist.
It might be a bug, couldn' test this with 3.0.15 (last release for the 3.0.x serie).
I updated the test TestRepairCursor, everything should be fine now!

domodwyer · 2017-10-03T10:49:00Z

Thanks @feliixx!

domodwyer

A slightly enthusiastic search and replace has had a few collateral changes! :)

Really appreciate taking the time to add the references to the Mongo documentation in the godoc comments, a brilliant idea 👍

@globalsign/hv the breaking change in GridFS?

domodwyer · 2017-10-03T11:35:45Z

bson/bson.go

@@ -83,13 +83,13 @@ const (
 	BinaryGeneric     byte = 0x00
 	BinaryFunction    byte = 0x01
 	BinaryBinaryOld   byte = 0x02
-	BinaryUUIDOld     byte = 0x03
-	BinaryUUID        byte = 0x04
+	BinaryUUIdOld     byte = 0x03


I think these got swept up in a find-and-replace - should still be ID

domodwyer · 2017-10-03T11:36:55Z

bson/bson.go

 type RawDocElem struct {
 	Name  string
 	Value Raw
 }

-// ObjectId is a unique ID identifying a BSON value. It must be exactly 12 bytes
+// ObjectId is a unique Id identifying a BSON value. It must be exactly 12 bytes
 // long. MongoDB objects by default have such a property set in their "_id"
 // property.


Accidental ID/Id replace (url broken)

domodwyer · 2017-10-03T11:37:17Z

bson/bson.go

@@ -447,7 +447,7 @@ var Undefined undefined
 //   0x00 - Generic. This is decoded as []byte(data), not Binary{0x00, data}.
 //   0x01 - Function (!?)
 //   0x02 - Obsolete generic.
-//   0x03 - UUID
+//   0x03 - UUId


domodwyer · 2017-10-03T11:37:33Z

bson/bson_corpus_spec_test.go

@@ -740,15 +740,15 @@ func (s *S) TestDBPointer_type__deprecated__String_not_null_terminated(c *C) {
 	testDecodeError(c, b, &resultD)
 }

-func (s *S) TestDBPointer_type__deprecated__short_OID__less_than_minimum_length_for_field_(c *C) {
+func (s *S) TestDBPointer_type__deprecated__short_OId__less_than_minimum_length_for_field_(c *C) {


domodwyer · 2017-10-03T11:37:36Z

bson/bson_corpus_spec_test.go

 	b, err := hex.DecodeString("160000000C61000300000061620056E1FC72E0C91700")
 	c.Assert(err, IsNil)

 	var resultD bson.D
 	testDecodeError(c, b, &resultD)
 }

-func (s *S) TestDBPointer_type__deprecated__short_OID__greater_than_minimum__but_truncated_(c *C) {
+func (s *S) TestDBPointer_type__deprecated__short_OId__greater_than_minimum__but_truncated_(c *C) {


domodwyer · 2017-10-03T11:52:25Z

txn/txn.go

@@ -394,7 +399,7 @@ func (r *Runner) Resume(id bson.ObjectId) (err error) {
 //
 // Saved documents are in the format:
 //
-//     {"_id": <txn id>, <collection>: {"d": [<doc id>, ...], "r": [<doc revno>, ...]}}
+//     {"_id": <txn Id>, <collection>: {"d": [<doc Id>, ...], "r": [<doc revno>, ...]}}


accidental capitalisation

domodwyer · 2017-10-03T11:52:43Z

txn/txn.go

@@ -481,11 +486,11 @@ func (r *Runner) PurgeMissing(collections ...string) error {
 	return nil
 }

-func (r *Runner) load(id bson.ObjectId) (*transaction, error) {
+func (r *Runner) load(Id bson.ObjectId) (*transaction, error) {


accidental capitalisation

domodwyer · 2017-10-03T11:52:47Z

txn/txn.go

@@ -438,7 +443,7 @@ func (r *Runner) PurgeMissing(collections ...string) error {
 					found[txnId] = true
 					continue
 				}
-				logf("WARNING: purging from document %s/%v the missing transaction id %s", collection, tdoc.Id, txnId)
+				logf("WARNING: purging from document %s/%v the missing transaction Id %s", collection, tdoc.Id, txnId)


accidental capitalisation

domodwyer · 2017-10-03T11:52:50Z

txn/txn.go

@@ -467,7 +472,7 @@ func (r *Runner) PurgeMissing(collections ...string) error {
 				found[txnId] = true
 				continue
 			}
-			logf("WARNING: purging from stash document %s/%v the missing transaction id %s", stdoc.Id.C, stdoc.Id.Id, txnId)
+			logf("WARNING: purging from stash document %s/%v the missing transaction Id %s", stdoc.Id.C, stdoc.Id.Id, txnId)


accidental capitalisation

domodwyer · 2017-10-03T11:53:00Z

txn/txn.go

@@ -542,7 +546,7 @@ func valueNature(v interface{}) (value interface{}, nature typeNature) {
 	case reflect.Struct:
 		return v, natureStruct
 	}
-	panic("document id type unsupported by txn: " + rv.Kind().String())
+	panic("document Id type unsupported by txn: " + rv.Kind().String())


accidental capitalisation

tadukurow · 2017-10-04T08:46:04Z

bson/bson.go

@@ -99,12 +99,12 @@ type Getter interface {
 	GetBSON() (interface{}, error)
 }

-// A value implementing the bson.Setter interface will receive the BSON
+// Setter interface : a value implementing the bson.Setter interface will receive the BSON


The space between "interface :" should be removed for consistency with the Getter comment. Very nitpicky this.

tadukurow · 2017-10-04T08:47:53Z

bson/bson.go

 // its respective zero value. When used in pointer values, this will set the
 // field to nil rather than to the pre-allocated value.
-var SetZero = errors.New("set to zero")
+var ErrSetZero = errors.New("set to zero")


Potentially breaks backwards compat for little gain I'd say. @domodwyer, not sure how likely is this to be used?

I don't think this is much of an issue, it's unlikely to be used by 99% of people.

FYI, I am one of the 1% that's affected by this change. Add reactions here for "me too".

tadukurow · 2017-10-04T08:50:06Z

gridfs.go

@@ -411,7 +432,7 @@ func (file *GridFile) ContentType() string {
 	return file.doc.ContentType
 }

-// ContentType changes the optional file content type.  An empty string may be
+// SetContentType changes the optional file content type.  An empty string may be


Doesn't look like an issue

tadukurow · 2017-10-04T08:50:26Z

gridfs_test.go

@@ -141,12 +141,12 @@ func (s *S) TestGridFSFileDetails(c *C) {
 	c.Assert(err, IsNil)
 	c.Assert(info, IsNil)

-	file.SetId("myid")
+	// file.setId("myid")


Any reason to keep this around?

tadukurow · 2017-10-04T08:52:03Z

internal/sasl/sasl.go

@@ -26,7 +26,8 @@ import (
 	"unsafe"
 )

-type saslStepper interface {
+// Stepper interface for saslSession
+type Stepper interface {


I agree the interface should be exported if returned from New.

see #43 for details ignore warning on Id/ID to keep fix backward compatible

@bozaro

* development: readme: credit @bozaro (#47) Fix GetBSON() method usage (#40) readme: credit @feliixx (#46) fix golint, go vet and gofmt warnings (#44) readme: add missing features / credit bson.Unmarshal returns time in UTC (#42) Introduce constants for BSON element types (#41) Test against MongoDB 3.4.x (#35) Add collation option to collection.Create() (#37) Don't panic on indexed int64 fields (#23) readme: credit @feliixx in the README (#36) add method CreateView() (#33) Update README to add appName (#32) send metadata during handshake (#28) readme: credit @feliixx for #25 (#26) add DropAllIndexes() method (#25) # Conflicts: # README.md # cluster.go # session.go # session_test.go

@feliixx

* add DropAllIndexes() method (#25) Create a new method to drop all the indexes of a collection in a single call * readme: credit @feliixx for #25 (#26) * send metadata during handshake (#28) fix [#484](https://github.com/go-mgo/mgo/issues/484) Annotate connections with metadata provided by the connecting client. informations send: { "aplication": { // optional "name": "myAppName" } "driver": { "name": "mgo", "version": "v2" }, "os": { "type": runtime.GOOS, "architecture": runtime.GOARCH } } to set "application.name", add `appname` param in options of string connection URI, for example : "mongodb://localhost:27017?appname=myAppName" * Update README to add appName (#32) * docs: elaborate on what appName does * readme: add appName to changes * add method CreateView() (#33) Fix #30. Thanks to @feliixx for the time and effort. * readme: credit @feliixx in the README (#36) * Don't panic on indexed int64 fields (#23) * Stop all db instances after tests (go-mgo#462) If all tests pass, the builds for mongo earlier than 2.6 are still failing. Running a clean up fixes the issue. * fixing int64 type failing when getting indexes and trying to type them * requested changes relating to case statement and panic * Update README.md to credit @mapete94. * tests: ensure indexed int64 fields do not cause a panic in Indexes() See: * #23 * https://github.com/go-mgo/mgo/issues/475 * go-mgo#476 * Add collation option to collection.Create() (#37) - Allow specifying the default collation for the collection when creating it. - Add some documentation to query.Collation() method. fix #29 * Test against MongoDB 3.4.x (#35) * test against MongoDB 3.4.x * tests: use listIndexes to assert index state for 3.4+ * make test pass against v3.4.x - skip `TestViewWithCollation` because of SERVER-31049, cf: https://jira.mongodb.org/browse/SERVER-31049 - add versionAtLeast() method in init.js script to better detect server version fixes #31 * Introduce constants for BSON element types (#41) * bson.Unmarshal returns time in UTC (#42) * readme: add missing features / credit * Adds missing collation feature description (by @feliixx). * Adds missing 3.4 tests description (by @feliixx). * Adds BSON constants description (by @bozaro). * Adds UTC time.Time unmarshalling (by @gazoon). * fix golint, go vet and gofmt warnings (#44) Fixes #43 * readme: credit @feliixx (#46) * Fix GetBSON() method usage (#40) * Fix GetBSON() method usage Original issue --- You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type. For example, you can't create custom GetBSON() for Bar type: ``` struct Foo { a Bar b *Bar } ``` Type implementation (`func (t Bar) GetBSON()` ) would crash on `Foo.b = nil` value encoding. Reference implementation (`func (t *Bar) GetBSON()` ) would not call on `Foo.a` value encoding. After this change --- For type implementation `func (t Bar) GetBSON()` would not call on `Foo.b = nil` value encoding. In this case `nil` value would be seariazied as `nil` BSON value. For reference implementation `func (t *Bar) GetBSON()` would call even on `Foo.a` value encoding. * Minor refactoring * readme: credit @bozaro (#47)

@bozaro

* commit '0454966c021aa1737c9680aceef7e2ba26952fe3': do not lock while writing to a socket (#52) (#54) readme: credit @bozaro and @idy (#53) Improve cursorData struct unmarshaling speed (#49) readme: credit @bozaro (#47) Fix GetBSON() method usage (#40) readme: credit @feliixx (#46) fix golint, go vet and gofmt warnings (#44) readme: add missing features / credit bson.Unmarshal returns time in UTC (#42) Introduce constants for BSON element types (#41) Test against MongoDB 3.4.x (#35) Add collation option to collection.Create() (#37) Don't panic on indexed int64 fields (#23) readme: credit @feliixx in the README (#36) add method CreateView() (#33) Update README to add appName (#32) send metadata during handshake (#28) readme: credit @feliixx for #25 (#26) add DropAllIndexes() method (#25) # Conflicts: # README.md # bson/decode.go

@feliixx

* add DropAllIndexes() method (#25) Create a new method to drop all the indexes of a collection in a single call * readme: credit @feliixx for #25 (#26) * send metadata during handshake (#28) fix [#484](https://github.com/go-mgo/mgo/issues/484) Annotate connections with metadata provided by the connecting client. informations send: { "aplication": { // optional "name": "myAppName" } "driver": { "name": "mgo", "version": "v2" }, "os": { "type": runtime.GOOS, "architecture": runtime.GOARCH } } to set "application.name", add `appname` param in options of string connection URI, for example : "mongodb://localhost:27017?appname=myAppName" * Update README to add appName (#32) * docs: elaborate on what appName does * readme: add appName to changes * add method CreateView() (#33) Fix #30. Thanks to @feliixx for the time and effort. * readme: credit @feliixx in the README (#36) * Don't panic on indexed int64 fields (#23) * Stop all db instances after tests (go-mgo#462) If all tests pass, the builds for mongo earlier than 2.6 are still failing. Running a clean up fixes the issue. * fixing int64 type failing when getting indexes and trying to type them * requested changes relating to case statement and panic * Update README.md to credit @mapete94. * tests: ensure indexed int64 fields do not cause a panic in Indexes() See: * #23 * https://github.com/go-mgo/mgo/issues/475 * go-mgo#476 * Add collation option to collection.Create() (#37) - Allow specifying the default collation for the collection when creating it. - Add some documentation to query.Collation() method. fix #29 * Test against MongoDB 3.4.x (#35) * test against MongoDB 3.4.x * tests: use listIndexes to assert index state for 3.4+ * make test pass against v3.4.x - skip `TestViewWithCollation` because of SERVER-31049, cf: https://jira.mongodb.org/browse/SERVER-31049 - add versionAtLeast() method in init.js script to better detect server version fixes #31 * Introduce constants for BSON element types (#41) * bson.Unmarshal returns time in UTC (#42) * readme: add missing features / credit * Adds missing collation feature description (by @feliixx). * Adds missing 3.4 tests description (by @feliixx). * Adds BSON constants description (by @bozaro). * Adds UTC time.Time unmarshalling (by @gazoon). * fix golint, go vet and gofmt warnings (#44) Fixes #43 * readme: credit @feliixx (#46) * Fix GetBSON() method usage (#40) * Fix GetBSON() method usage Original issue --- You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type. For example, you can't create custom GetBSON() for Bar type: ``` struct Foo { a Bar b *Bar } ``` Type implementation (`func (t Bar) GetBSON()` ) would crash on `Foo.b = nil` value encoding. Reference implementation (`func (t *Bar) GetBSON()` ) would not call on `Foo.a` value encoding. After this change --- For type implementation `func (t Bar) GetBSON()` would not call on `Foo.b = nil` value encoding. In this case `nil` value would be seariazied as `nil` BSON value. For reference implementation `func (t *Bar) GetBSON()` would call even on `Foo.a` value encoding. * Minor refactoring * readme: credit @bozaro (#47) * Improve cursorData struct unmarshaling speed (#49) This change remove full BSON decoding on: - parsing to `bson.Raw` and `bson.DocElem` fields; - skipping unused BSON fields. * readme: credit @bozaro and @idy (#53) * readme: credit @bozaro and @idy * readme: add @idy to contributor list * do not lock while writing to a socket (#52) (#54) fix #51

@feliixx

* add DropAllIndexes() method (globalsign#25) Create a new method to drop all the indexes of a collection in a single call * readme: credit @feliixx for globalsign#25 (globalsign#26) * send metadata during handshake (globalsign#28) fix [#484](https://github.com/go-mgo/mgo/issues/484) Annotate connections with metadata provided by the connecting client. informations send: { "aplication": { // optional "name": "myAppName" } "driver": { "name": "mgo", "version": "v2" }, "os": { "type": runtime.GOOS, "architecture": runtime.GOARCH } } to set "application.name", add `appname` param in options of string connection URI, for example : "mongodb://localhost:27017?appname=myAppName" * Update README to add appName (globalsign#32) * docs: elaborate on what appName does * readme: add appName to changes * add method CreateView() (globalsign#33) Fix globalsign#30. Thanks to @feliixx for the time and effort. * readme: credit @feliixx in the README (globalsign#36) * Don't panic on indexed int64 fields (globalsign#23) * Stop all db instances after tests (go-mgo#462) If all tests pass, the builds for mongo earlier than 2.6 are still failing. Running a clean up fixes the issue. * fixing int64 type failing when getting indexes and trying to type them * requested changes relating to case statement and panic * Update README.md to credit @mapete94. * tests: ensure indexed int64 fields do not cause a panic in Indexes() See: * globalsign#23 * https://github.com/go-mgo/mgo/issues/475 * go-mgo#476 * Add collation option to collection.Create() (globalsign#37) - Allow specifying the default collation for the collection when creating it. - Add some documentation to query.Collation() method. fix globalsign#29 * Test against MongoDB 3.4.x (globalsign#35) * test against MongoDB 3.4.x * tests: use listIndexes to assert index state for 3.4+ * make test pass against v3.4.x - skip `TestViewWithCollation` because of SERVER-31049, cf: https://jira.mongodb.org/browse/SERVER-31049 - add versionAtLeast() method in init.js script to better detect server version fixes globalsign#31 * Introduce constants for BSON element types (globalsign#41) * bson.Unmarshal returns time in UTC (globalsign#42) * readme: add missing features / credit * Adds missing collation feature description (by @feliixx). * Adds missing 3.4 tests description (by @feliixx). * Adds BSON constants description (by @bozaro). * Adds UTC time.Time unmarshalling (by @gazoon). * fix golint, go vet and gofmt warnings (globalsign#44) Fixes globalsign#43 * readme: credit @feliixx (globalsign#46) * Fix GetBSON() method usage (globalsign#40) * Fix GetBSON() method usage Original issue --- You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type. For example, you can't create custom GetBSON() for Bar type: ``` struct Foo { a Bar b *Bar } ``` Type implementation (`func (t Bar) GetBSON()` ) would crash on `Foo.b = nil` value encoding. Reference implementation (`func (t *Bar) GetBSON()` ) would not call on `Foo.a` value encoding. After this change --- For type implementation `func (t Bar) GetBSON()` would not call on `Foo.b = nil` value encoding. In this case `nil` value would be seariazied as `nil` BSON value. For reference implementation `func (t *Bar) GetBSON()` would call even on `Foo.a` value encoding. * Minor refactoring * readme: credit @bozaro (globalsign#47)

@feliixx

* add DropAllIndexes() method (globalsign#25) Create a new method to drop all the indexes of a collection in a single call * readme: credit @feliixx for globalsign#25 (globalsign#26) * send metadata during handshake (globalsign#28) fix [#484](https://github.com/go-mgo/mgo/issues/484) Annotate connections with metadata provided by the connecting client. informations send: { "aplication": { // optional "name": "myAppName" } "driver": { "name": "mgo", "version": "v2" }, "os": { "type": runtime.GOOS, "architecture": runtime.GOARCH } } to set "application.name", add `appname` param in options of string connection URI, for example : "mongodb://localhost:27017?appname=myAppName" * Update README to add appName (globalsign#32) * docs: elaborate on what appName does * readme: add appName to changes * add method CreateView() (globalsign#33) Fix globalsign#30. Thanks to @feliixx for the time and effort. * readme: credit @feliixx in the README (globalsign#36) * Don't panic on indexed int64 fields (globalsign#23) * Stop all db instances after tests (go-mgo#462) If all tests pass, the builds for mongo earlier than 2.6 are still failing. Running a clean up fixes the issue. * fixing int64 type failing when getting indexes and trying to type them * requested changes relating to case statement and panic * Update README.md to credit @mapete94. * tests: ensure indexed int64 fields do not cause a panic in Indexes() See: * globalsign#23 * https://github.com/go-mgo/mgo/issues/475 * go-mgo#476 * Add collation option to collection.Create() (globalsign#37) - Allow specifying the default collation for the collection when creating it. - Add some documentation to query.Collation() method. fix globalsign#29 * Test against MongoDB 3.4.x (globalsign#35) * test against MongoDB 3.4.x * tests: use listIndexes to assert index state for 3.4+ * make test pass against v3.4.x - skip `TestViewWithCollation` because of SERVER-31049, cf: https://jira.mongodb.org/browse/SERVER-31049 - add versionAtLeast() method in init.js script to better detect server version fixes globalsign#31 * Introduce constants for BSON element types (globalsign#41) * bson.Unmarshal returns time in UTC (globalsign#42) * readme: add missing features / credit * Adds missing collation feature description (by @feliixx). * Adds missing 3.4 tests description (by @feliixx). * Adds BSON constants description (by @bozaro). * Adds UTC time.Time unmarshalling (by @gazoon). * fix golint, go vet and gofmt warnings (globalsign#44) Fixes globalsign#43 * readme: credit @feliixx (globalsign#46) * Fix GetBSON() method usage (globalsign#40) * Fix GetBSON() method usage Original issue --- You can't use type with custom GetBSON() method mixed with structure field type and structure field reference type. For example, you can't create custom GetBSON() for Bar type: ``` struct Foo { a Bar b *Bar } ``` Type implementation (`func (t Bar) GetBSON()` ) would crash on `Foo.b = nil` value encoding. Reference implementation (`func (t *Bar) GetBSON()` ) would not call on `Foo.a` value encoding. After this change --- For type implementation `func (t Bar) GetBSON()` would not call on `Foo.b = nil` value encoding. In this case `nil` value would be seariazied as `nil` BSON value. For reference implementation `func (t *Bar) GetBSON()` would call even on `Foo.a` value encoding. * Minor refactoring * readme: credit @bozaro (globalsign#47) * Improve cursorData struct unmarshaling speed (globalsign#49) This change remove full BSON decoding on: - parsing to `bson.Raw` and `bson.DocElem` fields; - skipping unused BSON fields. * readme: credit @bozaro and @idy (globalsign#53) * readme: credit @bozaro and @idy * readme: add @idy to contributor list * do not lock while writing to a socket (globalsign#52) (globalsign#54) fix globalsign#51

domodwyer added the enhancement label Sep 28, 2017

domodwyer requested review from szank, brknstrngz, tadukurow and domodwyer October 3, 2017 10:49

domodwyer suggested changes Oct 3, 2017

View reviewed changes

tadukurow reviewed Oct 4, 2017

View reviewed changes

domodwyer previously approved these changes Oct 4, 2017

View reviewed changes

fix golint, go vet and gofmt warnings

6081229

see #43 for details ignore warning on Id/ID to keep fix backward compatible

feliixx dismissed domodwyer’s stale review via 6081229 October 5, 2017 06:18

domodwyer approved these changes Oct 6, 2017

View reviewed changes

domodwyer merged commit 97bd0cd into globalsign:development Oct 6, 2017

This was referenced Oct 6, 2017

readme: credit @feliixx #46

Merged

Fix GetBSON() method usage #40

Merged

domodwyer mentioned this pull request Oct 11, 2017

Merge Development #48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix golint, go vet and go fmt #44

fix golint, go vet and go fmt #44

feliixx commented Sep 28, 2017 •

edited

Loading

domodwyer commented Sep 28, 2017

feliixx commented Sep 28, 2017

domodwyer commented Sep 29, 2017

feliixx commented Oct 2, 2017

domodwyer commented Oct 3, 2017

domodwyer left a comment

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

domodwyer Oct 3, 2017

tadukurow Oct 4, 2017

tadukurow Oct 4, 2017

domodwyer Oct 4, 2017

medicalwei Feb 12, 2018

tadukurow Oct 4, 2017

tadukurow Oct 4, 2017

tadukurow Oct 4, 2017

fix golint, go vet and go fmt #44

fix golint, go vet and go fmt #44

Conversation

feliixx commented Sep 28, 2017 • edited Loading

domodwyer commented Sep 28, 2017

feliixx commented Sep 28, 2017

domodwyer commented Sep 29, 2017

feliixx commented Oct 2, 2017

domodwyer commented Oct 3, 2017

domodwyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feliixx commented Sep 28, 2017 •

edited

Loading