Fix npmignore #658
Closed
Fix npmignore #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rxaviers
force-pushed
the
fix-npmignore
branch
from
40dafad to
b431b73
Compare
rxaviers
added a commit
to rxaviers/globalize
that referenced
this pull request
Dec 14, 2016
Used negate expressions in package.json files entry, although it goes against recommendation below, because that's the only thing that worked. > "The consequences are undefined" if you try to negate any of the files > entries (that is, "!foo.js"). Please don't. Use .npmignore. https://github.com/npm/npm/wiki/Files-and-Ignores#details Fixes globalizejs#649 Closes globalizejs#658
|
Using this for now, we can revisit this in the future. |
Used negate expressions in package.json files entry, although it goes against recommendation below, because that's the only thing that worked. Read the github references below for details. > "The consequences are undefined" if you try to negate any of the files > entries (that is, "!foo.js"). Please don't. Use .npmignore. https://github.com/npm/npm/wiki/Files-and-Ignores#details Fixes globalizejs#649 Closes globalizejs#658
rxaviers
force-pushed
the
fix-npmignore
branch
from
b431b73 to
e41b263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done several tests and was surprised by the several failed attempts to get files ignored in published package.
.npmignore..gitignores (from examples) into/.gitignore, but it didn't help. I don't understand why these entries are simply not taken into account bynpm(tested v3.9.6 from node 5).https://github.com/npm/npm/wiki/Files-and-Ignores#details
PS: By the way, I used
tar -tf $(npm pack)to test a publish, a workaround for a dry run.