Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebase to use new angular 17 standalone components and control flow #4277

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

msmannan00
Copy link
Member

  1. Replaced deprecated control flow directives with the latest syntax.
  2. Converted components to standalone, removing NgModules.
  3. Updated route definitions with standalone component-based routing.
  4. Optimized lazy loading using new route-based syntax.
  5. Cleaned up dependencies and ensured compatibility with the latest Angular version.

@msmannan00 msmannan00 requested a review from a team as a code owner October 21, 2024 12:51
Copy link

codacy-production bot commented Oct 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.16% (target: -1.00%) 93.57% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (842d52a) 18603 15144 81.41%
Head commit (9b90d95) 32694 (+14091) 26995 (+11851) 82.57% (+1.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4277) 824 771 93.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@evilaliv3
Copy link
Member

Thank you @msmannan00

Very interesting patch. Apparently the code coverage pagges from 81.39 to 81.85 with this change.

Since you changed a very large set of files we should get sure that the files that you touched contains the updates that were included in the latest changes to the codebase in the devel branch.

@evilaliv3
Copy link
Member

@msmannan00 : This is an example of "regression" where with your proposal you are reintroducing some old code.

I will give it a try to find other situations like this.

image

@msmannan00
Copy link
Member Author

Yup, actually in past two weeks I tried to take merge from stable version twice and make changes accordingly but even then I might have missed some commits that were made in the week

@evilaliv3 evilaliv3 force-pushed the migration-of-angular17-deprecations branch 6 times, most recently from f42a75c to 62f9d64 Compare October 23, 2024 12:48
@evilaliv3
Copy link
Member

Very good to go! Merging!

msmannan00 and others added 2 commits October 23, 2024 16:20
…ol flow

1. Replaced deprecated control flow directives with the latest syntax.
2. Converted components to standalone, removing NgModules.
3. Updated route definitions with standalone component-based routing.
4. Optimized lazy loading using new route-based syntax.
5. Cleaned up dependencies and ensured compatibility with the latest Angular version.
@evilaliv3 evilaliv3 force-pushed the migration-of-angular17-deprecations branch from 62f9d64 to 6ee9e21 Compare October 23, 2024 14:22
@evilaliv3 evilaliv3 changed the title Angular 17 depreciation migrations Update codebase to use new angular 17 standalone components and control flow Oct 23, 2024
@evilaliv3 evilaliv3 merged commit b50ca5e into devel Oct 23, 2024
5 of 6 checks passed
@evilaliv3 evilaliv3 deleted the migration-of-angular17-deprecations branch October 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants