-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codebase to use new angular 17 standalone components and control flow #4277
Conversation
msmannan00
commented
Oct 21, 2024
- Replaced deprecated control flow directives with the latest syntax.
- Converted components to standalone, removing NgModules.
- Updated route definitions with standalone component-based routing.
- Optimized lazy loading using new route-based syntax.
- Cleaned up dependencies and ensured compatibility with the latest Angular version.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Thank you @msmannan00 Very interesting patch. Apparently the code coverage pagges from 81.39 to 81.85 with this change. Since you changed a very large set of files we should get sure that the files that you touched contains the updates that were included in the latest changes to the codebase in the devel branch. |
@msmannan00 : This is an example of "regression" where with your proposal you are reintroducing some old code. I will give it a try to find other situations like this. |
Yup, actually in past two weeks I tried to take merge from stable version twice and make changes accordingly but even then I might have missed some commits that were made in the week |
f42a75c
to
62f9d64
Compare
Very good to go! Merging! |
…ol flow 1. Replaced deprecated control flow directives with the latest syntax. 2. Converted components to standalone, removing NgModules. 3. Updated route definitions with standalone component-based routing. 4. Optimized lazy loading using new route-based syntax. 5. Cleaned up dependencies and ensured compatibility with the latest Angular version.
62f9d64
to
6ee9e21
Compare