Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xli branch update #6

Merged
merged 19 commits into from
Oct 21, 2024
Merged

Xli branch update #6

merged 19 commits into from
Oct 21, 2024

Conversation

zhoumo2716
Copy link
Contributor

I have successfully created the tests and the .github workflow in the xli-branch of the repository. Currently, I am focusing on testing the tvdenoising function.

@zhoumo2716 zhoumo2716 requested a review from dajmcdon October 16, 2024 18:21
.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
tests/testthat/test-tvdenoising.R Outdated Show resolved Hide resolved
tests/testthat/test-tvdenoising.R Outdated Show resolved Hide resolved
tests/testthat/test-tvdenoising.R Outdated Show resolved Hide resolved
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the action for Windows.

.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
extra-packages: any::rcmdcheck devtools testthat
needs: check

- uses: r-lib/actions/check-r-package@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line here will actually run all the tests as well.

.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
@dajmcdon dajmcdon merged commit 35c4f34 into main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants