Time Update #352
Merged
Time Update #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinscott
reviewed
Apr 18, 2018
src/UCTSearch.cpp
Outdated
| @@ -499,6 +500,7 @@ int UCTSearch::get_search_time() { | |||
| bool UCTSearch::should_halt_search() { | |||
| if (uci_stop) return true; | |||
| auto elapsed_millis = now() - m_start_time; | |||
| if (elapsed_millis > m_max_time) return true; | |||
There was a problem hiding this comment.
I think we only want to check this if target_time < 0?
There was a problem hiding this comment.
Yep, perhaps move to || along with m_target_time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies TM, implements max time, increases Slow Mover to 111 (temporary measure).