This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Fix argument ordering for setComponentTemplate
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setComponentTemplate API differs from the Ember version in two ways: 1. It's arguments are backwards. It should accept the template value as the first value, and the class as the second. 2. It is optional to recieve a component class. In the Ember version, if no class is provided, a TemplateOnlyComponent is created instead. This PR updates the implementation here to match.
pzuraq
force-pushed
the
bugfix/fix-set-component-template-api
branch
from
d5fd0b5 to
849ec5e
Compare
rwjblue
changed the title
setComponentTemplate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has the component class and template parameters backwards. This PR updates the implementation here to match Ember's.