This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Update to prettier@2 and ensure it is enforced by eslint
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are from files that should be excluded from prettier (babel plugin fixture files that are asserting the expected output from babel). |
* Updates to prettier@ (see [blog post](https://prettier.io/blog/2020/03/21/2.0.0.html) for details). * Fix issue with prettier linting setup (prettier was not being enforced by `eslint` prior to these changes). * Fix typo in `.eslintignore` (`fixture-options` -> `fixtures-options`)
rwjblue
force-pushed
the
update-prettier
branch
2 times, most recently
from
3b02606 to
915b15b
Compare
rwjblue
changed the title
prettier@2 and ensure it is enforced by eslint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslintprior to these changes).yarn lint --fixto fix all the files.This will be easiest to review by looking at the first commit on its own, as the second commit is
eslint --fix .basically.