This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
[FEATURE] Adds Owner #240
Merged
[FEATURE] Adds Owner #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feature/add-host-meta
branch
5 times, most recently
from
4d59532
to
d8fb158
Compare
pzuraq
requested review from
tomdale,
chadhietala,
chancancode,
rwjblue and
wycats
pzuraq
force-pushed
the
feature/add-host-meta
branch
2 times, most recently
from
ba20d1d
to
d8bcac6
Compare
|
I don't fully grok why we need a new concept here, vs using the pre-existing |
pzuraq
force-pushed
the
feature/add-host-meta
branch
from
d8bcac6
to
fceab9c
Compare
pzuraq
force-pushed
the
feature/add-host-meta
branch
2 times, most recently
from
827ee11
to
2a782a5
Compare
|
This also removes support for Ember < 3.8 as well, removing the legacy component managers for Glimmer components |
rwjblue
reviewed
Mar 9, 2020
pzuraq
force-pushed
the
feature/add-host-meta
branch
from
2a782a5
to
d857a74
Compare
rwjblue
reviewed
Mar 9, 2020
rwjblue
reviewed
Mar 9, 2020
pzuraq
force-pushed
the
feature/add-host-meta
branch
from
d857a74
to
e71e44f
Compare
Adds a `owner` argument that can be passed to `renderComponent`. This
value is provided to every manager in that render tree via the manager
factory:
```js
setComponentManager((owner) => new CustomManager(owner), {});
```
Conceptually, the owner here is similar to the owner in Ember.js.
Glimmer.js creates a new manager for each unique owner that it receives,
and managers can use the `getOwner` and `setOwner` methods to assign it
to passed objects. The owner is an opaque value, so it's up to the
embedding environment to decide what its API is. If no owner is passed,
a default owner is used, and throws an error if the user attempts to use
it for anything.
pzuraq
force-pushed
the
feature/add-host-meta
branch
from
e71e44f
to
f8fd34a
Compare
rwjblue
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
ownerargument that can be passed torenderComponent. Thisvalue is provided to every manager in that render tree via the manager
factory:
Conceptually, the owner here is similar to the owner in Ember.js.
Glimmer.js creates a new manager for each unique owner that it receives,
and managers can use the
getOwnerandsetOwnermethods to assign itto passed objects. The owner is an opaque value, so it's up to the
embedding environment to decide what its API is. If no owner is passed,
a default owner is used, and throws an error if the user attempts to use
it for anything.
Breaking changes: