Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Merge pull request #234 from glimmerjs/remove-compiler-from-runtime #234

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

chadhietala
Copy link
Member

@chadhietala chadhietala commented Feb 1, 2020

When you pull in @glimmer/compiler you will pull in the entire server-side compiler stack causing the runtime to be over 2MB.

It's unclear why this function was added because it doesn't seem to be used at all. Was introduced here #170

Copy link
Member

@pzuraq pzuraq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@pzuraq pzuraq changed the title [BUGFIX REGRESSION] Remove compile time functionality from runtime code Merge pull request #234 from glimmerjs/remove-compiler-from-runtime Feb 3, 2020
@pzuraq pzuraq merged commit 980a02a into master Feb 3, 2020
@pzuraq pzuraq deleted the remove-compiler-from-runtime branch February 3, 2020 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants