Expose isSerializationFirstNode and SERIALIZATION_FIRST_NODE_STRING #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes a mechanicsm that can be used in all the places in ember.js / fastboot and anywhere it might be necessary to determine whether or not a given node is the first serialization node. Which is useful to ensure that the actual format can change without affecting the other libaries who will be able to use this instead of a magic string. The rationale for this PR can be found in greater detail at the issue below: glimmerjs#787
|
I wanted to expose a function that could be used to better insulate future changes rather than only export a constant. |
|
This is immediately relevant to the following PRs ember-fastboot/ember-cli-fastboot#580 and |
rondale-sc
added a commit
to rondale-sc/ember.js
that referenced
this pull request
Feb 27, 2018
This is dependent on this glimmer-vm PR to actually work glimmerjs/glimmer-vm#788. Which means we'll need to wait until it is merged/bumped and Ember itself updates to use the release with it in it before we can land this. The idea here is to insulate things that depend on the magic string we use to determine whether or not the DOM node we pass was produced by the serialization element builder. This needs to be exposed on the global to ensure we can use it in the ember-cli-fastboot vendor file so we can determine how to boot the app when it is loaded in the browser. To see where it'd be used in ember-cli-fastboot please see this PR with the in progress work: ember-fastboot/ember-cli-fastboot#580
rondale-sc
added a commit
to rondale-sc/ember-cli-fastboot
that referenced
this pull request
Feb 27, 2018
This is dependent on glimmerjs/glimmer-vm#788 The idea is to use a function exported by ember-glimmer rather than rely on magic glimmer-vm string.
rwjblue
approved these changes
Mar 1, 2018
rondale-sc
added a commit
to rondale-sc/ember.js
that referenced
this pull request
Mar 6, 2018
This is dependent on this glimmer-vm PR to actually work glimmerjs/glimmer-vm#788. Which means we'll need to wait until it is merged/bumped and Ember itself updates to use the release with it in it before we can land this. The idea here is to insulate things that depend on the magic string we use to determine whether or not the DOM node we pass was produced by the serialization element builder. This needs to be exposed on the global to ensure we can use it in the ember-cli-fastboot vendor file so we can determine how to boot the app when it is loaded in the browser. To see where it'd be used in ember-cli-fastboot please see this PR with the in progress work: ember-fastboot/ember-cli-fastboot#580
rondale-sc
added a commit
to rondale-sc/ember-cli-fastboot
that referenced
this pull request
Mar 7, 2018
This is dependent on glimmerjs/glimmer-vm#788 The idea is to use a function exported by ember-glimmer rather than rely on magic glimmer-vm string.
rondale-sc
added a commit
to rondale-sc/ember-cli-fastboot
that referenced
this pull request
Mar 10, 2018
This is dependent on glimmerjs/glimmer-vm#788 The idea is to use a function exported by ember-glimmer rather than rely on magic glimmer-vm string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a mechanicsm that can be used in all the places in ember.js
/ fastboot and anywhere it might be necessary to determine whether or
not a given node is the first serialization node. Which is useful to
ensure that the actual format can change without affecting the other
libaries who will be able to use this instead of a magic string.
The rationale for this PR can be found in greater detail at the issue
below:
#787