Initial stab at porting asm/stack.ts to Rust
#752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
reviewed
Dec 1, 2017
| #![feature(link_llvm_intrinsics)] | ||
|
|
||
| #[no_mangle] | ||
| pub extern fn add(a: u32, b: u32) -> u32 { |
There was a problem hiding this comment.
Oops yeah that was just leftover
alexcrichton
force-pushed
the
more-rust
branch
from
f0e451c to
3edb642
Compare
|
The three currently failing tests I believe are
|
|
Is the idea that you'll be able to have pluggable backends within |
|
@wycats ok I pushed up the extra commits we talked about here! I think I addressed most of the immediate feedback and left a few questions, but let me know if there's anything else that should be resolved! |
alexcrichton
force-pushed
the
more-rust
branch
3 times, most recently
from
f04aa88 to
af48783
Compare
alexcrichton
force-pushed
the
more-rust
branch
from
96784fa to
164d730
Compare
|
@alexcrichton just in case, I can assure you that this table of wasm support by browsers is absolutely accurate https://caniuse.com/#feat=wasm |
|
@chicoxyzzy confirm! |
alexcrichton
force-pushed
the
more-rust
branch
from
ac23a69 to
542ced3
Compare
Should hopefully get further on CI!
The QUnit tests should now properly only start when the framework is loaded, and otherwise an extra level of indirection was needed to ensure that once wasm bindings were loaded they propagated correctly throughout the system.
Hopefully high-paced development is now over!
We don't want to accidentally use libstd abstractions too unnecessarily just yet as they may bring in too much code size.
This is a helper defined in the `wasm_bindgen` crate for if we need it, which we may!
This moves the interface and various imports over to using the `wasm_bindgen!` macro. This enables a few nice features: * Less duplication all over the place when adding a method, now you just add it then call it from JS. * Ability to pass JS objects "through Rust" in a way that removes a bunch of globals/wrappers on the JS side of things. * Hopefully more type safety and type checking long-term heading off bugs before they start to arise.
This also removes the `asm/stack.ts` file in favor of just going through the original `LowLevelVM` itself
Due to recursive usage patterns it's not always possible, but if we can use it then it's more efficient
This way we should cros the JS <-> wasm boundary hopefully a little less often.
Hopefully that'll get it to optimize *even more*, or at least that's the idea
The wasm-bindgen pass may remove functions and modify data (currently), so be sure to run wasm-opt afterwards to get maximal optimizations and space savings. For example dropping the wasm-bindgen statics drops the file size from 48k to 21k with this!
…okenizer Upgrade simple-html-tokenizer
Typing cleanup
…izer-dep fix simple-html-tokenizer deps
add prettierrc
remove for of usage causing problems with upstream build
Switch one instance of zero-initialization to not zero-initializing as well to save some perf
|
is it alive? |
|
Any news here? |
|
It's somewhat alive, but we've been focusing our efforts on Ember integration lately. @chriskrycho is taking a stab at porting the compiler to Rust/wasm with some very promising results so far! |
|
Was this completed, or abandoned? Either way it would be interesting to hear some details of the experience here! |
|
Is there any update regarding the VM migration to Wasm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an initial stab at adding some Rust to glimmer, notably to
implement some bits-and-pieces of the
low-levelpackage for now. Specificallythis commit takes the
Stacktype in thelow-levelmodule and ports it toRust and then integrates it all back with WebAssembly.
Some notable points of this:
right just yet.
standard library's allocator is avoided) and internally a freelist is
maintained of free'd pages.
forever in use and usage will "grow without bound". Eventually a manual call
to "free this" will need to be inserted for the
Stacktype.