Migrate partial-test following issue #561 guidelines #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
requested changes
Jul 15, 2017
| QUnit.test('static partial with named arguments', () => { | ||
| env.registerBasicComponent('foo-bar', BasicComponent, `<p>{{@foo}}-{{partial 'test'}}</p>`); | ||
| this.assertStableRerender(); | ||
| this.assertHTML('Respeck my name. When my name come up put some respeck on it.'); |
There was a problem hiding this comment.
Can you add an update and reset step for this.
this.rerender({ item: 'age' });
this.assertHTML('Respeck my age. When my age come up put some respeck on it.');
this.assertStableNodes();
this.rerender({ item: 'name' });
this.assertStableNodes();
this.assertHTML('Respeck my name. When my name come up put some respeck on it.');
|
|
||
| rerender(null, { assertStable: true }); | ||
| this.rerender(props); |
There was a problem hiding this comment.
This is basically doing the same thing as L39. Can you add an update and reset step like I mentioned above.
|
@lbdm44 As part of porting the tests we would like to get more coverage in the cases. In all of the units that are dynamic can you add the update and reset steps like I mentioned above? Also when we are re-rendering we want to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of partial-test.ts according to #561.