Migrate compile and syntax errors #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
migrate-compiler-errors
branch
from
c97c00c to
65b584a
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #561.
This migrates tests previously known as "compiler-error-test.js" and tests within "initial-render-test.js". This PR moves the tests contained in those files to 2 new files, "invalid-html-errors-test.js" and "syntax-errors-test.js". The names of these files better describe what they are testing. Tests dealing with invalid html that would surface through the HTML Tokenizer are in the "invalid-html-errors" file, where invalid handlebars syntax test cases are in the "syntax-errrors" file. This allows us to compartmentalize the non-"just html" error cases into a single place.