Streamline and modernize naming #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit continues the process of clearly documenting how the methods on `VM` affect the VM state. - Removes a number of duplicate methods that made the surface of the VM seem more elaborate than it actually is. - Consolidates the various "contexts" further to clarify the different kinds of state and the conditions under which they can change. - Further cleanup the debug state to make it clearer when explicit snapshots are necessary but allow stable objects on `debug` when they are appropriate.
wycats
force-pushed
the
internals/streamline-and-modernize-naming
branch
from
4f64f7e
to
7d7d1bd
Compare
| export type RemoteLiveBlock = SimpleLiveBlock; | ||
|
|
||
| export interface UpdatableBlock extends SimpleLiveBlock { | ||
| /** |
There was a problem hiding this comment.
I like these much better than their previous names
| readonly stdlib: STDLib; | ||
|
|
||
| /** | ||
| * A framework-specified resolver for resolving free variables in classic templates. |
There was a problem hiding this comment.
I super appreciate all these inline comments!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out the naming and documentation changes in #1649 so they can be landed separately.
The naming changes are focused on: