Support lexical scope in loose mode #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to pass lexically scoped values into templates even when those templates are not in strict mode. The whole system is already designed to make this work correctly, all that is required is to not actively stop it from working.
This use case is hugely useful as a compile target for embroider because embroider already does built-time resolution of components and helpers in existing (non-strict) templates. Today our compiler output does:
With this feature it can become:
which means we skip over a large amount of runtime registration and lookup.