Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using a nested WeakMap for manager instances for a given owner. #1347

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Avoid using a nested WeakMap for manager instances for a given owner. #1347

merged 1 commit into from
Oct 18, 2021

Commits on Oct 18, 2021

  1. Avoid using a nested WeakMap for manager instances for a given owner. 

    The first level WeakMap is sufficient to prevent memory leaks. The only
potential value that the second level WeakMap provides is to allow us to
_unload_ code during the lifetime of a single owner instance, which is
really not something that we support.

Having nested WeakMap's breaks some tooling around memory leak
investigation that we commonly use.
    @rwjblue
    rwjblue committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    30d57fc View commit details
    Browse the repository at this point in the history