Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused scope from Walker #1341

Merged
merged 1 commit into from
Sep 27, 2021

Commits on Sep 24, 2021

  1. Remove unused scope from Walker

    The `scope` info here is entirely unused in the Glimmer codebase. It may
    be used in some AST transforms, but this is fairly unlikely, since it
    has only been available since Ember 3.16. Profiling template compilation
    highlighted the recursive walking of the whole tree for locals in scope
    during syntax parsing as a major cost in CPU usage, so the hope is that
    removing this will help.
    chriskrycho committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    393decf View commit details
    Browse the repository at this point in the history