Merge pull request #1402 from boris-petrov/fix-on-modifier

Allow passing `false` to the `on` modifier's options
glimmerjs · Dec 15, 2022 · ec5648f · ec5648f
2 parents 03a4b55 + c6370fc
commit ec5648f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/@glimmer/runtime/lib/modifiers/on.ts b/packages/@glimmer/runtime/lib/modifiers/on.ts
@@ -83,7 +83,9 @@ export class OnModifierState {
     }
 
     let options: AddEventListenerOptions;
-    if (once || passive || capture) {
+    // we want to handle both `true` and `false` because both have a meaning:
+    // https://bugs.chromium.org/p/chromium/issues/detail?id=770208
+    if (once !== undefined || passive !== undefined || capture !== undefined) {
       options = this.options = { once, passive, capture };
     } else {
       this.options = undefined;