Add exactOptionalPropertyTypes

glimmerjs · May 4, 2023 · dd43f67 · dd43f67
1 parent a81c716
commit dd43f67
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/build/broccoli/write-smoke-test.js b/build/broccoli/write-smoke-test.js
@@ -33,6 +33,8 @@ class TypesSmokeTestWriter extends Plugin {
           noUnusedLocals: true,
           noUnusedParameters: true,
           noImplicitReturns: true,
+          useDefineForClassFields: true,
+          exactOptionalPropertyTypes: true,
 
           newLine: 'LF',
           noEmit: true,

diff --git a/packages/@glimmer/syntax/lib/traversal/errors.ts b/packages/@glimmer/syntax/lib/traversal/errors.ts
@@ -7,7 +7,7 @@ export interface TraversalError extends Error {
   key: string;
   node: ASTv1.Node;
   parent: Option<ASTv1.Node>;
-  stack: string | undefined;
+  stack?: string | undefined;
 }
 
 export interface TraversalErrorConstructor {

diff --git a/packages/@glimmer/vm/tsconfig.json b/packages/@glimmer/vm/tsconfig.json
@@ -19,6 +19,8 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
+    "useDefineForClassFields": true,
+    "exactOptionalPropertyTypes": true,
 
     "newLine": "LF",
     "noEmit": true,

diff --git a/tsconfig.json b/tsconfig.json
@@ -22,7 +22,7 @@
     "noUnusedParameters": true,
     "noImplicitReturns": true,
     "useDefineForClassFields": true,
-    // "exactOptionalPropertyTypes": true,
+    "exactOptionalPropertyTypes": true,
     // "noImplicitOverride": true,
     // "noPropertyAccessFromIndexSignature": true,
     // "noUncheckedIndexedAccess": true,