Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for extensibility #148

Merged
merged 6 commits into from
Jul 25, 2022

Conversation

dfreeman
Copy link
Contributor

This PR proposes a few changes to the types in order to provide tools like Glint the hooks necessary to augment them with additional information for template validation. In particular, it:

It also adds a very basic type test suite using expect-type

Ping (low urgency) @chriskrycho for a sanity-check 🙂

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple questions and a couple typo fixes but 👍🏼

Co-authored-by: Chris Krycho <[email protected]>
@chadhietala
Copy link
Member

@chriskrycho @dfreeman Just wondering whats left to do here as it seems like this is the last PR to remove the glimmerx re-exports in glint.

@dfreeman
Copy link
Contributor Author

I think all that's needed here is a merge and release from a maintainer. Once that's done we'll need to make some corresponding changes in @glint/environment-glimmerx and publish a new release of that as well.

@chadhietala chadhietala merged commit db5b467 into glimmerjs:master Jul 25, 2022
@chadhietala
Copy link
Member

I merged this but looks like the tests are failing on master, not just the ember ones that I think were failing before this.

@dfreeman
Copy link
Contributor Author

Looks like an outdated Babel version. I'll see if I can get a PR together to get tests green more generally

@dfreeman dfreeman mentioned this pull request Jul 25, 2022
@dfreeman
Copy link
Contributor Author

dfreeman commented Jul 25, 2022

@chadhietala things should be ✅ across the board in #154

@chadhietala chadhietala added the enhancement New feature or request label Jul 25, 2022
@chadhietala
Copy link
Member

@dfreeman 0.6.7 is released with these changes

@dfreeman
Copy link
Contributor Author

@chadhietala Thanks! Hopefully we should be able to get an updated @glint/environment-glimmerx out in the next week or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants