-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types for extensibility #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple questions and a couple typo fixes but 👍🏼
Co-authored-by: Chris Krycho <[email protected]>
@chriskrycho @dfreeman Just wondering whats left to do here as it seems like this is the last PR to remove the glimmerx re-exports in glint. |
I think all that's needed here is a merge and release from a maintainer. Once that's done we'll need to make some corresponding changes in |
I merged this but looks like the tests are failing on master, not just the ember ones that I think were failing before this. |
Looks like an outdated Babel version. I'll see if I can get a PR together to get tests green more generally |
@chadhietala things should be ✅ across the board in #154 |
@dfreeman 0.6.7 is released with these changes |
@chadhietala Thanks! Hopefully we should be able to get an updated |
This PR proposes a few changes to the types in order to provide tools like Glint the hooks necessary to augment them with additional information for template validation. In particular, it:
on
andfn
using the same approach as [ember] Add declarations for strict-mode template entities DefinitelyTyped/DefinitelyTyped#58606hbs
andhelper()
, following the same approach as [@ember/component/helper] MakeFunctionBasedHelper
an (abstract) constructor type DefinitelyTyped/DefinitelyTyped#59714It also adds a very basic type test suite using
expect-type
Ping (low urgency) @chriskrycho for a sanity-check 🙂