Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning & attachment fixes #933

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Display warning & attachment fixes #933

merged 5 commits into from
Jan 25, 2021

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi linked an issue Jan 19, 2021 that may be closed by this pull request
@DigneshGujarathi DigneshGujarathi added this to the v0.9.4 milestone Jan 19, 2021
@DigneshGujarathi DigneshGujarathi self-assigned this Jan 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #933 (2239c6b) into master (34ced1d) will increase coverage by 0.10%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   67.99%   68.09%   +0.10%     
==========================================
  Files         146      146              
  Lines        3871     3874       +3     
  Branches      791      792       +1     
==========================================
+ Hits         2632     2638       +6     
+ Misses        970      966       -4     
- Partials      269      270       +1     
Impacted Files Coverage Δ
.../Chat/ChatMessages/AddAttachment/AddAttachment.tsx 44.00% <25.00%> (+0.52%) ⬆️
...ntainers/Chat/ChatMessages/ChatInput/ChatInput.tsx 64.92% <50.00%> (-0.49%) ⬇️
src/containers/List/List.tsx 70.51% <0.00%> (+1.92%) ⬆️
src/components/UI/Timer/Timer.tsx 77.27% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ced1d...2239c6b. Read the comment docs.

@mdshamoon mdshamoon modified the milestones: v0.9.4, v0.9.5 Jan 21, 2021
@mdshamoon mdshamoon modified the milestones: v0.9.5, v0.9.6 Jan 22, 2021
@mdshamoon
Copy link
Member

Looks good.

@mdshamoon mdshamoon merged commit fe2238d into master Jan 25, 2021
@mdshamoon mdshamoon deleted the bug/speed-send branch January 25, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip for unsupported animated stickers & attachments with captions Speed send issues
3 participants