Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order by fixes #930

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Order by fixes #930

merged 2 commits into from
Jan 19, 2021

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Jan 19, 2021

Summary

Test Plan

  • Not needed

@kurund kurund requested a review from mdshamoon January 19, 2021 01:03
@kurund kurund self-assigned this Jan 19, 2021
@kurund kurund requested a review from rathorevaibhav January 19, 2021 01:05
@kurund kurund added this to the v0.9.5 milestone Jan 19, 2021
DigneshGujarathi
DigneshGujarathi reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@DigneshGujarathi DigneshGujarathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DigneshGujarathi DigneshGujarathi merged commit 34ced1d into master Jan 19, 2021
@DigneshGujarathi DigneshGujarathi deleted the order-by-fixes branch January 19, 2021 12:22
This was linked to issues Jan 20, 2021
Postgrex.Error: ERROR 42703 (undefined_column) column s0.desc does not exist #938
Closed
Postgrex.Error: ERROR 42703 (undefined_column) column s0.desc does not exist #929
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigneshGujarathi DigneshGujarathi DigneshGujarathi left review comments

@mdshamoon mdshamoon Awaiting requested review from mdshamoon

@rathorevaibhav rathorevaibhav Awaiting requested review from rathorevaibhav

Assignees

@kurund kurund

Labels
None yet
Projects
None yet
Milestone
v0.9.5
2 participants
@kurund @DigneshGujarathi