Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for dependable field #860

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi self-assigned this Dec 28, 2020
@DigneshGujarathi DigneshGujarathi linked an issue Dec 28, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #860 (646441c) into master (8c6933f) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   69.68%   69.57%   -0.12%     
==========================================
  Files         142      142              
  Lines        3704     3707       +3     
  Branches      750      751       +1     
==========================================
- Hits         2581     2579       -2     
- Misses        866      870       +4     
- Partials      257      258       +1     
Impacted Files Coverage Δ
src/containers/Template/Form/Template.tsx 39.18% <33.33%> (-0.54%) ⬇️
src/containers/List/List.tsx 73.28% <0.00%> (-2.30%) ⬇️
...ntainers/Chat/ChatMessages/ChatInput/ChatInput.tsx 65.41% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6933f...646441c. Read the comment docs.

Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdshamoon mdshamoon merged commit 211471d into master Dec 28, 2020
@mdshamoon mdshamoon deleted the bug/attachment-validation branch December 28, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create media speed send throwing an error
3 participants