Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send OTP twice bug resolved #837

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Send OTP twice bug resolved #837

merged 2 commits into from
Dec 22, 2020

Conversation

mdshamoon
Copy link
Member

@mdshamoon mdshamoon commented Dec 21, 2020

@codecov-io
Copy link

Codecov Report

Merging #837 (73fa646) into master (f507273) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files         141      141           
  Lines        3538     3538           
  Branches      714      714           
=======================================
  Hits         2501     2501           
  Misses        784      784           
  Partials      253      253           
Impacted Files Coverage Δ
src/containers/Auth/Auth.tsx 90.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f507273...73fa646. Read the comment docs.

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdshamoon @DigneshGujarathi Removing "type=submit" results in old behavior where we cannot submit the login form using the 'enter' key. I have added an additional fix to handle that case. Can you please verify both the fixes at your end?

@mdshamoon
Copy link
Member Author

Working fine for me 👍. It's handling both cases.

@kurund kurund merged commit 88a21f7 into master Dec 22, 2020
@kurund kurund deleted the bug/send-otp branch December 22, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In registration page when I click on continue it calls the send-otp API twice.
3 participants