Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variable popup #825

Merged
merged 11 commits into from
Dec 28, 2020
Merged

Added variable popup #825

merged 11 commits into from
Dec 28, 2020

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi linked an issue Dec 17, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #825 (48e3e2f) into master (333b244) will decrease coverage by 0.28%.
The diff coverage is 50.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   70.00%   69.71%   -0.29%     
==========================================
  Files         141      142       +1     
  Lines        3624     3702      +78     
  Branches      738      750      +12     
==========================================
+ Hits         2537     2581      +44     
- Misses        835      863      +28     
- Partials      252      258       +6     
Impacted Files Coverage Δ
src/containers/Chat/ChatMessages/ChatMessages.tsx 48.12% <0.00%> (-1.50%) ⬇️
...ntainers/Chat/ChatMessages/ChatInput/ChatInput.tsx 65.15% <39.53%> (-7.49%) ⬇️
...rs/Chat/ChatMessages/AddVariables/AddVariables.tsx 65.71% <65.71%> (ø)
src/common/constants.ts 100.00% <100.00%> (ø)
src/components/UI/DialogBox/DialogBox.tsx 93.10% <100.00%> (+0.24%) ⬆️
...mponents/UI/Form/WhatsAppEditor/WhatsAppEditor.tsx 62.50% <100.00%> (ø)
...ntact/BlockContactList/BlockContact.test.helper.ts 100.00% <100.00%> (ø)
...BlockContact/BlockContactList/BlockContactList.tsx 96.55% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b244...48e3e2f. Read the comment docs.

@DigneshGujarathi DigneshGujarathi self-assigned this Dec 17, 2020
@DigneshGujarathi DigneshGujarathi added this to the v0.8.4 milestone Dec 17, 2020
@kurund kurund modified the milestones: v0.8.4, v0.8.5 Dec 17, 2020
@kurund kurund modified the milestones: v0.8.5, v0.8.6 Dec 22, 2020
@mdshamoon
Copy link
Member

Testing feedbacks:

  1. The default height of chat Input is increased. This is affecting the alignment of icons and the placeholder.

image

  1. If a template has no variable, it's treating it like a normal message in the chat input field and we are able to edit that.

image

@mdshamoon
Copy link
Member

Testing feedback:

Account update template has 3 variables but in the dialog box, it's showing only one.

image

image

@mdshamoon
Copy link
Member

Looks good.

@mdshamoon mdshamoon merged commit fc7df04 into master Dec 28, 2020
@mdshamoon mdshamoon deleted the feature/template-variable branch December 28, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop-up to add input variables to templates
4 participants