Update chat templates #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-frontend into feature/chat-templates
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 72.25% 70.58% -1.68%
==========================================
Files 141 141
Lines 3385 3512 +127
Branches 665 710 +45
==========================================
+ Hits 2446 2479 +33
- Misses 698 781 +83
- Partials 241 252 +11
Continue to review full report at Codecov.
|
| const dialogMessage = ' It will stop showing when you are drafting a customized message.'; | ||
|
|
||
| const defaultTypeAttribute = { | ||
| type: 'TEXT', | ||
| // type: 'TEXT', |
There was a problem hiding this comment.
is this needed or can be removed easily?
src/containers/Form/FormLayout.tsx
Outdated
| @@ -216,6 +222,38 @@ export const FormLayout: React.SFC<FormLayoutProps> = ({ | |||
| return null; | |||
| } | |||
|
|
|||
| const getMediaId = (payload: any) => { | |||
There was a problem hiding this comment.
I think this is not something we should include in FormLayout.tsx. Maybe in parent or maybe we create another (generic) wrapper around FormLayout that deals with media. Let me know your thoughts.
There was a problem hiding this comment.
@rathorevaibhav I have fixed this, please review.
…to feature/chat-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan