Updating Conversation Queries #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claalmve
commented
Jun 25, 2020
| @@ -17,6 +17,7 @@ const App = () => { | |||
| <Route path="/tag" exact component={TagPage} /> | |||
| <Route path="/tag/add" exact component={Tag} /> | |||
| <Route path="/tag/:id/edit" exact component={Tag} /> | |||
| {/* Doesn't this error without a passed in `contactId`? */} | |||
There was a problem hiding this comment.
Because I was getting an error page on the default /chat route, I did a little digging into it, and I believe because contactId is never passed in for this route, the page will not render properly. So, I'm not completely sure how this worked before, or if I did something wrong on my end, but now to see the page properly, you need to add a ID at the end of the URL (i.e. localhost:3000/chat/2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the conversation GraphQL endpoints. Addresses #77 .
Test Plan
Passes all current tests in components using these queries.