Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's mask the phone number #727

Merged
merged 14 commits into from
Nov 24, 2020
Merged

let's mask the phone number #727

merged 14 commits into from
Nov 24, 2020

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Nov 20, 2020

Summary

Test Plan

  • Included in the PR

@kurund kurund linked an issue Nov 20, 2020 that may be closed by this pull request
@kurund kurund added this to the v0.6.3 milestone Nov 22, 2020
@kurund kurund self-assigned this Nov 22, 2020
@codecov-io
Copy link

codecov-io commented Nov 22, 2020

Codecov Report

Merging #727 (d0a2e56) into master (5adab19) will decrease coverage by 0.10%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   69.67%   69.57%   -0.11%     
==========================================
  Files         139      139              
  Lines        3232     3260      +28     
  Branches      620      627       +7     
==========================================
+ Hits         2252     2268      +16     
- Misses        762      772      +10     
- Partials      218      220       +2     
Impacted Files Coverage Δ
...ntact/BlockContactList/BlockContact.test.helper.ts 100.00% <ø> (ø)
...ChatConversations/ChatConversations.test.helper.ts 100.00% <ø> (ø)
...onversations/ConversationList/ConversationList.tsx 45.76% <0.00%> (ø)
src/containers/Chat/ChatMessages/ChatMessages.tsx 56.09% <ø> (ø)
src/graphql/queries/Contact.ts 100.00% <ø> (ø)
src/graphql/queries/Search.ts 100.00% <ø> (ø)
src/mocks/Chat.tsx 80.95% <ø> (ø)
src/mocks/Contact.tsx 100.00% <ø> (ø)
src/mocks/User.tsx 100.00% <ø> (ø)
src/containers/Profile/Profile.tsx 60.00% <42.85%> (-1.77%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adab19...d0a2e56. Read the comment docs.

@rathorevaibhav
Copy link
Contributor

hey @kurund sorry about the late comment. All things looking good. Just one minor thing. On the contact description page, when we click on the eye icon it slightly shifts to the left as the spacing increases when numbers are fully displayed vs when they're masked. Do you think this is something we should fix or can leave it be?

@kurund
Copy link
Contributor Author

kurund commented Nov 24, 2020

@rathorevaibhav I will fix it. Good catch :)

@kurund
Copy link
Contributor Author

kurund commented Nov 24, 2020

@rathorevaibhav Ready for your review again. Also fixed the phone value for a staff role user and added a tooltip.

@rathorevaibhav rathorevaibhav merged commit 769f5d4 into master Nov 24, 2020
@rathorevaibhav rathorevaibhav deleted the masked-phone branch November 24, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number masking
3 participants