-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let's mask the phone number #727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 69.67% 69.57% -0.11%
==========================================
Files 139 139
Lines 3232 3260 +28
Branches 620 627 +7
==========================================
+ Hits 2252 2268 +16
- Misses 762 772 +10
- Partials 218 220 +2
Continue to review full report at Codecov.
|
hey @kurund sorry about the late comment. All things looking good. Just one minor thing. On the contact description page, when we click on the eye icon it slightly shifts to the left as the spacing increases when numbers are fully displayed vs when they're masked. Do you think this is something we should fix or can leave it be? |
@rathorevaibhav I will fix it. Good catch :) |
@rathorevaibhav Ready for your review again. Also fixed the phone value for a staff role user and added a tooltip. |
Summary
Test Plan