Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning to React testing library from Enzyme #696

Merged
merged 17 commits into from
Nov 17, 2020

Conversation

rathorevaibhav
Copy link
Contributor

@rathorevaibhav rathorevaibhav commented Nov 9, 2020

Summary

Converted for the following components:

  • Pager
  • SearchDialogBox
  • DialogBox
  • DropdownDialog
  • Button
  • Dropdown
  • Input
  • PhoneInput
  • Loading

Also, minor test cleanups are done and downgraded date-io package as it is not supported in the latest material-ui/pickers package
https://material-ui-pickers.dev/getting-started/installation

@rathorevaibhav rathorevaibhav self-assigned this Nov 9, 2020
@rathorevaibhav rathorevaibhav changed the base branch from master to upgrade-packages November 9, 2020 14:21
@kurund kurund added this to the v0.6.3 milestone Nov 16, 2020
@rathorevaibhav rathorevaibhav marked this pull request as ready for review November 17, 2020 05:44
@rathorevaibhav rathorevaibhav linked an issue Nov 17, 2020 that may be closed by this pull request
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was one huge PR to review 👍

@kurund kurund merged commit 66ec862 into upgrade-packages Nov 17, 2020
@kurund kurund deleted the remove-enzyme-support branch November 17, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate enzyme to react testing
2 participants