Tab title will update according to the automation page #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurund
requested changes
Oct 28, 2020
.env.example
Outdated
| @@ -1,3 +1,5 @@ | |||
| REACT_APP_API_PREFIX="" | |||
| SENTRY_DSN="" | |||
| REACT_APP_GLIFIC_API_PORT=4000 | |||
| REACT_APP_APPLICATION_NAME="" | |||
There was a problem hiding this comment.
@rathorevaibhav why do we need an app name?
There was a problem hiding this comment.
hey @kurund I made these fields editable from env so that if needed, SaaS providers who extend Glific can rename it.
For example, like Tides, we can have App name set to "Tides" instead of "Glific". It's just so that we provide flexibility to extend the framework. If there's nothing set, the default value will come in which is "Glific". Let me know if this is making sense.
.env.example
Outdated
| @@ -1,3 +1,5 @@ | |||
| REACT_APP_API_PREFIX="" | |||
| SENTRY_DSN="" | |||
| REACT_APP_GLIFIC_API_PORT=4000 | |||
| REACT_APP_APPLICATION_NAME="" | |||
| REACT_APP_PAGE_TITLE="" | |||
There was a problem hiding this comment.
Why do we need to define title as env variable?
|
@kurund this is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The automation title will be appended to the title of the website. Also added environment variables for: