-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for adding bulk contacts to group #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rathorevaibhav Mostly everything is working as expected. However, I am getting this weird behavior when I search for contact and then select the contact. The form just breaks after that.
hey @kurund I tried a few combinations but couldn't replicate it. can you share some more details or maybe the exact steps you're doing? |
We already discussed, just adding it here for future reference. It happens when you try to search for a contact that is not part of the preloaded contacts. |
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 75.20% 73.97% -1.23%
==========================================
Files 133 133
Lines 2831 2974 +143
Branches 539 584 +45
==========================================
+ Hits 2129 2200 +71
- Misses 511 566 +55
- Partials 191 208 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and working as expected now.
Summary
We can add bulk contacts to a group from the group list screen