Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding bulk contacts to group #617

Merged
merged 10 commits into from
Oct 22, 2020
Merged

Conversation

rathorevaibhav
Copy link
Contributor

Summary

We can add bulk contacts to a group from the group list screen

@rathorevaibhav rathorevaibhav self-assigned this Oct 16, 2020
@rathorevaibhav rathorevaibhav linked an issue Oct 16, 2020 that may be closed by this pull request
@kurund kurund modified the milestones: v0.5.1, v0.5.2 Oct 19, 2020
@rathorevaibhav rathorevaibhav marked this pull request as ready for review October 20, 2020 11:06
@rathorevaibhav rathorevaibhav requested review from kurund and DigneshGujarathi and removed request for kurund October 20, 2020 11:06
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rathorevaibhav Mostly everything is working as expected. However, I am getting this weird behavior when I search for contact and then select the contact. The form just breaks after that.
Screenshot 2020-10-20 at 6 56 36 PM

@rathorevaibhav
Copy link
Contributor Author

hey @kurund I tried a few combinations but couldn't replicate it. can you share some more details or maybe the exact steps you're doing?

@kurund
Copy link
Contributor

kurund commented Oct 22, 2020

We already discussed, just adding it here for future reference. It happens when you try to search for a contact that is not part of the preloaded contacts.

@codecov-io
Copy link

Codecov Report

Merging #617 into master will decrease coverage by 1.22%.
The diff coverage is 51.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   75.20%   73.97%   -1.23%     
==========================================
  Files         133      133              
  Lines        2831     2974     +143     
  Branches      539      584      +45     
==========================================
+ Hits         2129     2200      +71     
- Misses        511      566      +55     
- Partials      191      208      +17     
Impacted Files Coverage Δ
src/graphql/mutations/Group.ts 100.00% <ø> (ø)
...c/components/UI/Form/AutoComplete/AutoComplete.tsx 59.18% <37.50%> (-15.82%) ⬇️
src/containers/Group/GroupList/GroupList.tsx 55.26% <46.51%> (-13.31%) ⬇️
src/containers/List/List.tsx 74.63% <62.50%> (-1.10%) ⬇️
.../components/UI/SearchDialogBox/SearchDialogBox.tsx 73.68% <64.28%> (-15.21%) ⬇️
...iners/Automation/AutomationList/AutomationList.tsx 100.00% <100.00%> (ø)
...BlockContact/BlockContactList/BlockContactList.tsx 96.55% <100.00%> (ø)
...gement/StaffManagementList/StaffManagementList.tsx 55.55% <100.00%> (ø)
src/mocks/Contact.tsx 100.00% <100.00%> (ø)
src/mocks/Group.tsx 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caed818...b400ba8. Read the comment docs.

@rathorevaibhav rathorevaibhav requested a review from kurund October 22, 2020 12:57
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working as expected now.

@kurund kurund merged commit 994503e into master Oct 22, 2020
@kurund kurund deleted the feature/add-contacts-to-group branch October 22, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding multiple contacts to a group
3 participants