Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi search #601

Merged
merged 22 commits into from
Oct 22, 2020
Merged

Added multi search #601

merged 22 commits into from
Oct 22, 2020

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi self-assigned this Oct 12, 2020
@DigneshGujarathi DigneshGujarathi added this to the v0.5 milestone Oct 12, 2020
@DigneshGujarathi DigneshGujarathi linked an issue Oct 12, 2020 that may be closed by this pull request
@kurund kurund modified the milestones: v0.5, v0.5.1 Oct 14, 2020
@rathorevaibhav rathorevaibhav modified the milestones: v0.5.1, v0.5.2 Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #601 into master will decrease coverage by 0.27%.
The diff coverage is 67.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   75.08%   74.81%   -0.28%     
==========================================
  Files         133      133              
  Lines        2814     2871      +57     
  Branches      536      552      +16     
==========================================
+ Hits         2113     2148      +35     
- Misses        510      523      +13     
- Partials      191      200       +9     
Impacted Files Coverage Δ
...ners/Chat/ChatMessages/ChatMessage/ChatMessage.tsx 76.38% <ø> (ø)
src/containers/Chat/ChatMessages/ChatMessages.tsx 58.87% <ø> (ø)
src/containers/List/List.test.helper.ts 100.00% <ø> (ø)
src/containers/List/List.tsx 75.73% <ø> (ø)
src/mocks/Chat.tsx 88.88% <0.00%> (-11.12%) ⬇️
...ntainers/Chat/ChatMessages/ChatInput/ChatInput.tsx 67.18% <33.33%> (-1.67%) ⬇️
...iners/Chat/ChatConversations/ChatConversations.tsx 53.42% <50.00%> (-0.31%) ⬇️
...edSearch/SavedSearchToolbar/SavedSearchToolbar.tsx 59.25% <50.00%> (-1.53%) ⬇️
...onversations/ChatConversation/ChatConversation.tsx 69.23% <66.66%> (+3.71%) ⬆️
...onversations/ConversationList/ConversationList.tsx 52.67% <71.87%> (+2.09%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e0bac...3e7d66e. Read the comment docs.

@kurund kurund requested a review from rathorevaibhav October 20, 2020 05:40
@rathorevaibhav
Copy link
Contributor

@DigneshGujarathi When I search and click on the message and if the conversation is already not loaded it gets stuck in the loading state. Not sure if I'm doing it right. I'll check again.

@rathorevaibhav
Copy link
Contributor

@DigneshGujarathi some testing feedbacks:

  1. When searching for a message and clicking on the contact which is initially not loaded in the search query, it gets stuck in the loading state

Screenshot from 2020-10-21 10-36-08
Screenshot from 2020-10-21 10-36-34
img

  1. The order of the search should be contact > messages > tags according to the sketch files. Currently its contact > tags > messages

  2. When the result is null the list area should not be blank. It can have a message like this- "no contact found".
    image

@kurund kurund removed their request for review October 21, 2020 10:08
@rathorevaibhav
Copy link
Contributor

@DigneshGujarathi One final thing I found on testing. When not searching for anything and clicking on any contact, it duplicates that contact in the list:

Screenshot from 2020-10-22 12-30-30

@rathorevaibhav rathorevaibhav merged commit 0aa922c into master Oct 22, 2020
@rathorevaibhav rathorevaibhav deleted the search branch October 22, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search implementation
4 participants