Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket URL fixes #560

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Socket URL fixes #560

merged 2 commits into from
Oct 6, 2020

Conversation

rathorevaibhav
Copy link
Contributor

Summary

Fixes for socket url protocol

@rathorevaibhav rathorevaibhav self-assigned this Oct 6, 2020
@rathorevaibhav rathorevaibhav linked an issue Oct 6, 2020 that may be closed by this pull request
Updates to socket protocol based on web protocol #561
Closed
kurund
kurund approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kurund kurund merged commit 8550aa3 into master Oct 6, 2020
@kurund kurund deleted the socket-url-fixes branch October 6, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund approved these changes

@DigneshGujarathi DigneshGujarathi Awaiting requested review from DigneshGujarathi

Assignees

@rathorevaibhav rathorevaibhav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates to socket protocol based on web protocol
2 participants
@rathorevaibhav @kurund