Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organisation language support #553

Merged
merged 5 commits into from
Oct 5, 2020
Merged

Conversation

rathorevaibhav
Copy link
Contributor

@rathorevaibhav rathorevaibhav commented Oct 1, 2020

Summary

Fixes to get active languages for user

Test Plan

Updated.

Note

For resources like tags, speed-sends, templates, profile etc where we have language dropdown, the active languages should show up fine. However, when you change the language, save, go to a different page and then come back, it'll still show the old language from the cache. Upon refresh, it's working fine.

This is currently being worked on on a separate branch.

@rathorevaibhav rathorevaibhav self-assigned this Oct 1, 2020
@rathorevaibhav rathorevaibhav linked an issue Oct 1, 2020 that may be closed by this pull request
@rathorevaibhav rathorevaibhav added this to the v0.3.4 milestone Oct 1, 2020
@rathorevaibhav rathorevaibhav requested a review from kurund October 5, 2020 07:02
@rathorevaibhav rathorevaibhav marked this pull request as ready for review October 5, 2020 07:02
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kurund kurund merged commit b691516 into master Oct 5, 2020
@kurund kurund deleted the organisation-language-support branch October 5, 2020 10:34
@kurund kurund modified the milestones: v0.3.4, v0.5 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to see languages in any language dropdown
2 participants