Session expiry #547
Merged
Session expiry #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathorevaibhav
approved these changes
Sep 29, 2020
|
@kurund the code changes look good. Just one query from testing: In case the user is opted out, we show the blocked icon. Should we also hide the chat input? |
|
@rathorevaibhav Actually for all practical purposes this user is like a blocked contact where you can't send a message. However, I feel showing input gives an indication that we can communicate with the user once we receive a message from them. So I feel current behavior might be fine. @abhi1203 Your thoughts on this? |
|
@rathorevaibhav I have made a fix to hide the input when the session has expired and the contact has not opted in. |
rathorevaibhav
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan