Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flows now fetching and publishing through uuid #488

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Flows now fetching and publishing through uuid #488

merged 2 commits into from
Sep 18, 2020

Conversation

rathorevaibhav
Copy link
Contributor

Summary

Flows are now fetching and publishing through uuid instead of id.
Also added an environment variable i.e. the editor link.

Test Plan

Updated

@rathorevaibhav rathorevaibhav requested review from kurund and removed request for kurund September 18, 2020 09:49
@rathorevaibhav rathorevaibhav linked an issue Sep 18, 2020 that may be closed by this pull request
@rathorevaibhav rathorevaibhav self-assigned this Sep 18, 2020
@rathorevaibhav rathorevaibhav added this to the v0.4 milestone Sep 18, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #488 into master will decrease coverage by 0.33%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   71.52%   71.18%   -0.34%     
==========================================
  Files         127      128       +1     
  Lines        2472     2506      +34     
  Branches      455      464       +9     
==========================================
+ Hits         1768     1784      +16     
- Misses        540      558      +18     
  Partials      164      164              
Impacted Files Coverage Δ
src/containers/Automation/Automation.tsx 47.50% <ø> (ø)
src/graphql/mutations/Automation.ts 100.00% <ø> (ø)
...rc/route/AuthenticatedRoute/AuthenticatedRoute.tsx 58.82% <ø> (ø)
src/components/floweditor/FlowEditor.tsx 86.66% <55.55%> (-2.81%) ⬇️
src/common/constants.ts 100.00% <100.00%> (ø)
...iners/Automation/AutomationList/AutomationList.tsx 100.00% <100.00%> (ø)
...ners/OrganisationSettings/OrganisationSettings.tsx 66.66% <0.00%> (-15.48%) ⬇️
...gement/StaffManagementList/StaffManagementList.tsx 55.55% <0.00%> (-11.12%) ⬇️
src/containers/Form/FormLayout.tsx 52.34% <0.00%> (-3.91%) ⬇️
src/containers/Tag/Tag.tsx 76.78% <0.00%> (-1.79%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e3efb...6514f3f. Read the comment docs.

@rathorevaibhav rathorevaibhav marked this pull request as ready for review September 18, 2020 11:20
@rathorevaibhav
Copy link
Contributor Author

@kurund ready for review again

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@kurund kurund merged commit ad42abe into master Sep 18, 2020
@kurund kurund deleted the flow-change branch September 18, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested flows url throws an error
3 participants