Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow editor changes #469

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Flow editor changes #469

merged 2 commits into from
Sep 16, 2020

Conversation

pankaj-ag
Copy link
Collaborator

@pankaj-ag pankaj-ag commented Sep 15, 2020 •
edited
Loading

Summary

  1. Moved the flow editor from origin to the Glific forked repo.
  2. Removed the action and operators from the flows which we are not using right now.
  3. You need to run the yarn install after merging this PR.

Test Plan

@rathorevaibhav
Copy link
Contributor

Getting CORS issue in Chrome. Seems like issue at browser end. Researching if something is needed on code level to update.

kurund
kurund approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine on the latest Chrome. I didn't have any CORS issue.

@kurund kurund merged commit 189f0a9 into master Sep 16, 2020
@kurund kurund deleted the flow-editor-changes branch September 16, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund approved these changes

@rathorevaibhav rathorevaibhav rathorevaibhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankaj-ag @rathorevaibhav @kurund