Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added update & create collection button #368

Merged
merged 17 commits into from
Sep 2, 2020
Merged

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi self-assigned this Aug 28, 2020
@DigneshGujarathi DigneshGujarathi linked an issue Aug 28, 2020 that may be closed by this pull request
2 tasks
@DigneshGujarathi DigneshGujarathi marked this pull request as ready for review August 28, 2020 13:11
@kurund kurund added this to the v0.3 milestone Aug 28, 2020
@kurund
Copy link
Contributor

kurund commented Aug 29, 2020

@DigneshGujarathi
Found a few issues:

  • setting default not working when search and modify search criteria
  • search does not refresh result set

@kurund
Copy link
Contributor

kurund commented Sep 1, 2020

@DigneshGujarathi Found an issue when we save a collection and then save another one using create new.

Basically, the issue occurs is when we try to create a new collection using an existing collection name.

Screenshot 2020-09-01 at 8 31 40 PM

payload.includeGroups = props.searchParam.includeGroups;
payload.dateTo = props.searchParam.dateTo;
payload.dateFrom = props.searchParam.dateFrom;
// payload.term = props.searchParam.term;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this code if not needed.

@kurund kurund merged commit 183725a into master Sep 2, 2020
@kurund kurund deleted the Collection-Enhancements branch September 2, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection Enhancements
2 participants