Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add contact to group #334

Merged
merged 16 commits into from
Aug 22, 2020
Merged

Feature/add contact to group #334

merged 16 commits into from
Aug 22, 2020

Conversation

rathorevaibhav
Copy link
Contributor

Summary

Add groups for a contact

Test Plan

Added

@rathorevaibhav rathorevaibhav self-assigned this Aug 17, 2020
@kurund kurund added this to the v0.3 milestone Aug 18, 2020
@rathorevaibhav rathorevaibhav requested a review from kurund August 18, 2020 13:24
@rathorevaibhav rathorevaibhav marked this pull request as ready for review August 18, 2020 13:24
@rathorevaibhav rathorevaibhav requested review from kurund and removed request for kurund August 18, 2020 13:28
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rathorevaibhav We need to change the UI to use autocomplete interface here too. The functionality is working fine. It might be good to confirm with @abhi1203 on this too.

@kurund
Copy link
Contributor

kurund commented Aug 22, 2020

@rathorevaibhav tested and working fine.

@kurund kurund merged commit 801363e into master Aug 22, 2020
@kurund kurund deleted the feature/add-contact-to-group branch August 22, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants