Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search functionality in collections dropdown #3074

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

akanshaaa19
Copy link
Member

target issue is #3071

@akanshaaa19 akanshaaa19 self-assigned this Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 14:06 Inactive
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (d9dd531) to head (5facf8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3074   +/-   ##
=======================================
  Coverage   80.19%   80.20%           
=======================================
  Files         322      322           
  Lines       10378    10382    +4     
  Branches     2213     2213           
=======================================
+ Hits         8323     8327    +4     
  Misses       1407     1407           
  Partials      648      648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund September 6, 2024 14:09
@akanshaaa19 akanshaaa19 linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link

cypress bot commented Sep 6, 2024

Glific    Run #5200

Run Properties:  status check passed Passed #5200  •  git commit 2c3c95d002 ℹ️: Merge 5facf8ba64fc0c53a7beb0295f68c1f83aaef36c into d9dd5317805d4c08a40914943974...
Project Glific
Branch Review fix/collections
Run status status check passed Passed #5200
Run duration 24m 05s
Commit git commit 2c3c95d002 ℹ️: Merge 5facf8ba64fc0c53a7beb0295f68c1f83aaef36c into d9dd5317805d4c08a40914943974...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurund kurund merged commit da575d1 into master Sep 9, 2024
12 of 13 checks passed
@kurund kurund deleted the fix/collections branch September 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Import: have searchable dropdown for collections
2 participants