Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scroll in t&c form #3067

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fixed scroll in t&c form #3067

merged 3 commits into from
Sep 6, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3066

@akanshaaa19 akanshaaa19 requested a review from kurund September 5, 2024 08:12
@akanshaaa19 akanshaaa19 self-assigned this Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3067--glific-frontend.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 5, 2024 08:13 Inactive
@akanshaaa19 akanshaaa19 linked an issue Sep 5, 2024 that may be closed by this pull request
T&C: Terms and conditions popup is not scrollable #3066
Closed
@cypress Cypress
Copy link

cypress bot commented Sep 5, 2024 •
edited
Loading

Glific    Run #5190

Run Properties:  status check passed Passed #5190  •  git commit c07ae3976f ℹ️: Merge e24e347533bf6131ece1fd0785f20bd7bad5b1dd into 7d7b2f34e0e99f828e1604c62e4b...
Project Glific
Branch Review fix/scroll
Run status status check passed Passed #5190
Run duration 24m 29s
Commit git commit c07ae3976f ℹ️: Merge e24e347533bf6131ece1fd0785f20bd7bad5b1dd into 7d7b2f34e0e99f828e1604c62e4b...
Committer Akansha Sakhre
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (7a38f90) to head (6d91b3a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files         322      322           
  Lines       10378    10378           
  Branches     2213     2213           
=======================================
  Hits         8323     8323           
  Misses       1407     1407           
  Partials      648      648

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request September 5, 2024 18:23 Inactive
kurund
kurund reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to scroll without any issues on Chrome.

Screenshot 2024-09-05 at 21 55 39

Are you checking on any specific browser?

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 08:18 Inactive
@kurund kurund merged commit d9dd531 into master Sep 6, 2024
12 checks passed
@kurund kurund deleted the fix/scroll branch September 6, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund left review comments

Assignees

@akanshaaa19 akanshaaa19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T&C: Terms and conditions popup is not scrollable
2 participants
@akanshaaa19 @kurund